Jump to content


* * * * * 1 votes

(Adriano) Favorite Topics v1.2


  • Please log in to reply
38 replies to this topic

#21 Tom

Tom

    Posting God

  • IM Supporters
  • PipPipPipPipPipPipPipPipPip
  • 1,541 posts
  • IPB Version:v2.3.x

Posted 22 January 2009 - 03:55 PM

View PostSOSInvision, on Jan 22 2009, 11:29 AM, said:

They have access but when they click, shows the default no permission error of IP.Board to those users!

I know. I'd feel more comfortable it would appear just for these groups which has been determined in ACP.
Issue is, that the error dialog is one of these "standard" explanations which is shows in a dozen different situations

View PostSOSInvision, on Jan 22 2009, 11:29 AM, said:

I gotta test this... You mean, they access index.php?act=UserCP&CODE=30 ?

If a user is not allowed to use it, why showing it that option in User CP? It confuses people. Right after installation I got 2 PMs with questions from that group which was excluded.

#22 Tom

Tom

    Posting God

  • IM Supporters
  • PipPipPipPipPipPipPipPipPip
  • 1,541 posts
  • IPB Version:v2.3.x

Posted 22 January 2009 - 04:16 PM

Adriano, may i ask you to use the next time english terms? Please do not misunderstand anything but I've again issues with the chars in ACP.
That doesnt looks nice so you'd do me a huge favor if you could tell me how I could fix this.

Also Is there a chance to re-name autocom=favoritos to autocom=bookmarks?

I will do it by hand if you can tell me where I have to find the related setting(s).


The Mod is great!

#23 Tom

Tom

    Posting God

  • IM Supporters
  • PipPipPipPipPipPipPipPipPip
  • 1,541 posts
  • IPB Version:v2.3.x

Posted 22 January 2009 - 06:07 PM

Issue: concern Statistic Page

If A Topic has benn removed and the user had just one topic bookmarked that the list contains an empty data record
Same empty row in UserCP
Also the counter wich shows the member with most favorited topics isnt re-set to the proper value

#24 Adriano Faria

Adriano Faria

    ...a curious guy...

  • Modders
  • PipPipPipPipPipPipPipPipPipPip
  • 3,268 posts
  • Location:Brazil
  • Real Name:Adriano
  • IPB Version:v3.3.x
Contributor

Posted 22 January 2009 - 11:25 PM

View PostTom, on Jan 22 2009, 01:55 PM, said:

I know. I'd feel more comfortable it would appear just for these groups which has been determined in ACP.
JS sucks on those menus.. if you look carefully, IPB in itself doesn't change some messages created by those menus. It would need another IF to test if that's a forum that can be used or not... sincerally, I don't think it's worth the job.

View PostTom, on Jan 22 2009, 01:55 PM, said:

Issue is, that the error dialog is one of these "standard" explanations which is shows in a dozen different situations
I think it's the most appropriate message to show! If you have no permission to use that function, the text is exacly that: you have no permission!

View PostTom, on Jan 22 2009, 02:16 PM, said:

Also Is there a chance to re-name autocom=favoritos to autocom=bookmarks?
You have to change it everywhere! It's just like TUTORIALS from Michael.. here (Brazil) we call it TUTORIAIS... there's a link on UPC to public component... your users doesn't have to keep in mind the name of the mod. The mod was designed on my language... after that, translated (lang_files) to EN.

Regarding UCP problem... open sources/action_public/usercp.php and find:

	function topico_favorito_list()
	{
Add below:

		if ( !in_array( $this->ipsclass->member['mgroup'], explode( ",", $this->ipsclass->vars['topicofav_grupos'] ) ) )
		{
			$this->ipsclass->Error( array( 'LEVEL' => 1, 'MSG' => 'no_permission' ) );
		}

View PostTom, on Jan 22 2009, 04:07 PM, said:

Issue: concern Statistic Page

If A Topic has benn removed and the user had just one topic bookmarked that the list contains an empty data record
Same empty row in UserCP
Also the counter wich shows the member with most favorited topics isnt re-set to the proper value
I'll take a look on that tomorrow!

#25 Tom

Tom

    Posting God

  • IM Supporters
  • PipPipPipPipPipPipPipPipPip
  • 1,541 posts
  • IPB Version:v2.3.x

Posted 23 January 2009 - 07:21 AM

View PostSOSInvision, on Jan 22 2009, 07:25 PM, said:

JS sucks on those menus.. if you look carefully, IPB in itself doesn't change some messages created by those menus. It would need another IF to test if that's a forum that can be used or not... sincerally, I don't think it's worth the job.

I can live with it, maybe I need to add a restriction in the template based on the usergroup


View PostSOSInvision, on Jan 22 2009, 07:25 PM, said:

Regarding UCP problem... open sources/action_public/usercp.php and find:

Works! (Error Message after clicking the link)


View PostSOSInvision, on Jan 22 2009, 07:25 PM, said:

I'll take a look on that tomorrow!

;)

#26 scottybt

scottybt

    n00b

  • Members
  • Pip
  • 4 posts
  • IPB Version:v2.3.x

Posted 31 January 2009 - 07:27 PM

Hi. I just installed Favorite Topics v1.2(yes I have Universal Mod Installer and [BoT] File Editor).

I've installed the mod though Universal Mod Installer, but I can't see it under view mods in File Editor.

What to do? Can I skip this step?

Scott

#27 Adriano Faria

Adriano Faria

    ...a curious guy...

  • Modders
  • PipPipPipPipPipPipPipPipPipPip
  • 3,268 posts
  • Location:Brazil
  • Real Name:Adriano
  • IPB Version:v3.3.x
Contributor

Posted 01 February 2009 - 09:28 PM

Yes. Make the manual edits: http://www.invisionm...s...st&p=151038

#28 scottybt

scottybt

    n00b

  • Members
  • Pip
  • 4 posts
  • IPB Version:v2.3.x

Posted 02 February 2009 - 04:39 PM

Ok thanks.

When going into Show my Favorite Topics in UCP i get a blank page. Whats wrong?

#29 Adriano Faria

Adriano Faria

    ...a curious guy...

  • Modders
  • PipPipPipPipPipPipPipPipPipPip
  • 3,268 posts
  • Location:Brazil
  • Real Name:Adriano
  • IPB Version:v3.3.x
Contributor

Posted 02 February 2009 - 09:12 PM

View Postscottybt, on Feb 2 2009, 02:39 PM, said:

When going into Show my Favorite Topics in UCP i get a blank page. Whats wrong?
Probably more than 1 function with the same name... Open sources/action_public/usercp.php and take a look on file...

Compare with those manual edits: http://www.invisionm...s...st&p=151038

#30 scottybt

scottybt

    n00b

  • Members
  • Pip
  • 4 posts
  • IPB Version:v2.3.x

Posted 09 February 2009 - 09:42 PM

*gone*

Edited by scottybt, 17 February 2009 - 02:02 PM.


#31 scottybt

scottybt

    n00b

  • Members
  • Pip
  • 4 posts
  • IPB Version:v2.3.x

Posted 12 February 2009 - 06:26 PM

Any helt please?  ;)

#32 Tom

Tom

    Posting God

  • IM Supporters
  • PipPipPipPipPipPipPipPipPip
  • 1,541 posts
  • IPB Version:v2.3.x

Posted 12 February 2009 - 09:17 PM

Adriano, do you plan to fix the bugs in the near future?

#33 Adriano Faria

Adriano Faria

    ...a curious guy...

  • Modders
  • PipPipPipPipPipPipPipPipPipPip
  • 3,268 posts
  • Location:Brazil
  • Real Name:Adriano
  • IPB Version:v3.3.x
Contributor

Posted 12 February 2009 - 10:05 PM

Yeah... I'm just ending 2 paid mods on my board. I'll come back to fix this and release another one.

#34 Doppelgaenger

Doppelgaenger

    Advanced Member

  • Members
  • PipPipPipPip
  • 56 posts
  • IPB Version:v2.3.x

Posted 21 March 2009 - 10:38 PM

still waiting, wink ;)

#35 Monkeyman

Monkeyman

    Coder

  • Members
  • PipPipPipPipPip
  • 120 posts
  • Location:Russia
  • Real Name:Dmitry
  • IPB Version:v3.0.x
Contributor

Posted 03 April 2009 - 06:18 AM

Somehow I don't have Favorite Topics block when I click PM (New messages) link in menu. It only appears when I click on My Controls.
I checked the corresponding skin - there is the same piece of code in Messenger -> Member bar. Bust still it doesn't display.

Any ideas?

#36 Adriano Faria

Adriano Faria

    ...a curious guy...

  • Modders
  • PipPipPipPipPipPipPipPipPipPip
  • 3,268 posts
  • Location:Brazil
  • Real Name:Adriano
  • IPB Version:v3.3.x
Contributor

Posted 03 April 2009 - 12:51 PM

It should be working...

		<language>
			<key>topico_favorito_list</key> 
			<text>Show my Favorite Topics</text> 
			<file>lang_msg</file> 
		</language>
		<language>
			<key>topico_favorito_title</key> 
			<text>Favorite Topics</text> 
			<file>lang_msg</file> 
		</language>
The installation creates lang for Messenger too.

#37 Monkeyman

Monkeyman

    Coder

  • Members
  • PipPipPipPipPip
  • 120 posts
  • Location:Russia
  • Real Name:Dmitry
  • IPB Version:v3.0.x
Contributor

Posted 03 April 2009 - 02:44 PM

Never said it shouldn't, but it somehow doesn't work for me.
Strange that menu_bar template in Messenger group marked as unedited. However, I can clearly see Favorite topics code:

<!-- SOS INVISION -->
<div class="subtitle">{$this->ipsclass->lang['topico_favorito_title']}</div>
<p>
 <{ITEM_START}> <a href="{$this->ipsclass->base_url}act=UserCP&CODE=30">{$this->ipsclass->lang['topico_favorito_list']}</a><br />
 <{ITEM_START}> <a href="{$this->ipsclass->base_url}autocom=favoritos">{$this->ipsclass->lang['topico_favorito_stats']}</a><br />
</p>

Probably, my skin cache or any other cache is messed somehow. Is there a way to completely and for sure rebuild skin templates?

Edited by Monkeyman, 03 April 2009 - 03:05 PM.


#38 toprobroy

toprobroy

    Member

  • Members
  • PipPipPip
  • 23 posts
  • Real Name:Robert
  • IPB Version:v2.3.x

Posted 15 September 2010 - 10:48 PM

HI, will this Mod work on 3.1.2
THere are a few people looking for something like this over on IPS Resources.
My link

#39 Adriano Faria

Adriano Faria

    ...a curious guy...

  • Modders
  • PipPipPipPipPipPipPipPipPipPip
  • 3,268 posts
  • Location:Brazil
  • Real Name:Adriano
  • IPB Version:v3.3.x
Contributor

Posted 15 September 2010 - 11:16 PM

No, it won't work but I can update it... I just don't have any ETA right now to tell you.




1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users